Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Android onLoad event when view width and height are zero #953

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

thomas-coldwell
Copy link

@thomas-coldwell thomas-coldwell commented Dec 15, 2022

Hey @DylanVann 👋

This PR aims to fix an existing issue with the onLoad event not firing on Android when the view style's width or height is zero as documented here #865. There is a similar PR #446 that was opened, but as mentioned in reviews this causes crashes due to the .override(Target.SIZE_ORIGINAL) method being applied to Glide. Instead, this PR follows the recommended way of getting the natural image dimensions as documented here in the Glide repo bumptech/glide#781 (comment).

The changes here include:

  • Adds a second target of a Size class with the relevant decoder + transcoder to achieve this
  • Aligns the onLoad method on Android to work in the same way iOS does - reporting the original natural image dimensions
  • Some minor dev setup fixes to get the example app up and running

These changes are best tested with the AutoSize component in the example app - as you can see setting the width to zero still triggers the onLoad event and this example is then rendered correctly.

@Beamanator
Copy link

@DylanVann Is there any chance you can let us know your thoughts on this change? @thomas-coldwell and I would be happy to discuss with you if you have any questions / concerns about this update

@Beamanator
Copy link

Bump? 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants