Feature/preload callbacks #437

Mickagd · 2019-03-26T17:26:17Z

We also need this PR to be merged

… and iOS

# Conflicts: # android/src/main/java/com/dylanvann/fastimage/FastImagePreloaderModule.java # src/index.d.ts # src/index.js

…preload-callbacks

guhungry

Please rename FastImagePreloaderModule back to FastImageViewModule and extract method into new class instead from preload()

guhungry · 2019-03-27T06:37:09Z

android/src/main/java/com/dylanvann/fastimage/FastImagePreloaderModule.java

 import com.facebook.react.bridge.ReactApplicationContext;
 import com.facebook.react.bridge.ReactContextBaseJavaModule;
 import com.facebook.react.bridge.ReactMethod;
 import com.facebook.react.bridge.ReadableArray;
 import com.facebook.react.bridge.ReadableMap;
 import com.facebook.react.views.imagehelper.ImageSource;

-class FastImageViewModule extends ReactContextBaseJavaModule {
+class FastImagePreloaderModule extends ReactContextBaseJavaModule {


Why rename class just like that. I have #425 which edit FastImageViewModule.java

codecov · 2019-03-28T14:31:07Z

Codecov Report

Merging #437 (c86abda) into main (a7a8643) will decrease coverage by 45.01%.
The diff coverage is 17.39%.

❗ Current head c86abda differs from pull request most recent head 0ee6e1f. Consider uploading reports for the commit 0ee6e1f to get more accurate results

@@             Coverage Diff             @@
##             main     #437       +/-   ##
===========================================
- Coverage   96.29%   51.28%   -45.02%     
===========================================
  Files           1        2        +1     
  Lines          27       39       +12     
  Branches        2        0        -2     
===========================================
- Hits           26       20        -6     
- Misses          1       19       +18

Impacted Files	Coverage Δ
src/preloaderManager.js	`15.78% <15.78%> (ø)`
src/index.js	`85.00% <25.00%> (ø)`
src/index.tsx

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d8c749...0ee6e1f. Read the comment docs.

RWOverdijk · 2019-05-13T15:21:24Z

Hey all! Is this going somewhere?

augustbjornberg · 2019-05-17T18:40:29Z

Is this PR still being worked on? Would be such a nice feature to have.

Ilphrin · 2019-05-28T14:50:52Z

There are some conflicts, I think you should resolve them @Mickagd before @DylanVann can take a look at this PR ^^

SamiChab · 2019-06-12T09:54:26Z

Please consider implementing this! It would be so useful!

Update from original repository

RWOverdijk · 2019-06-19T11:52:58Z

Really happy to see this still moving forward! I can't wait to remove my component hack 😄

LuisRodriguezLD · 2019-08-21T00:56:29Z

Hello. Any update on this?

RWOverdijk · 2019-08-21T05:46:40Z

@LuisRodriguezLD As far as I can see there are conflicts.

RWOverdijk · 2019-10-12T08:59:34Z

I've reimplemented this. Confirmed to work on iOS. Android I'll check later. I'll make a PR when I'm done.

On a sidenote, my solution uses a lot less code so I'm hoping that makes it easier to get it merged.

Elindorath · 2019-10-15T16:54:08Z

Hi @RWOverdijk. Thanks for your work! Could you publish your reimplementation on your fork that we can help to test it and speed up this to get it merged?

We really need this to be compatible with RN v0.60+.

RWOverdijk · 2019-10-15T17:06:08Z

@Elindorath Sure thing. I have to finish android first though. The module is compatible with 0.60+ for me, so I'm not sure what you mean

Sync with the original repo

joan-saum · 2019-11-04T11:02:24Z

Hi @RWOverdijk , how is it going with Android ? :) Need any help ?

sebqq · 2019-11-05T12:32:10Z

Promise should also return which pictures from array couldn't be fetched, not only how many couldn't be fetched.

RWOverdijk · 2019-11-05T13:22:56Z

@joan-saum It's going all right. The biggest problem right now is time and priorities. I can push the iOS stuff at some point this or next week though, maybe someone else can then PR the android stuff to my branch and we can get this thing going!

Sorry for my lack of time... It bothers me as well.

sebqq · 2019-11-11T08:49:48Z

Please, consider to also add id to every image, so we can check from react-native side which images failed to load.

RWOverdijk · 2019-11-11T10:22:20Z

@sebinq I will not be doing that but you could add that after if you want.

sebqq · 2019-11-11T10:23:24Z

@RWOverdijk thanks for info,, I will try.

RWOverdijk · 2020-01-23T08:50:52Z

The problem is that my project isn't selling well enough to prioritize this feature (My sales strategy was well calculated but man, am I bad at math.).

…allbacks-fetch-updates-2021-08-18

…dd callback to preload function

…dates-2021-08-18 Feature/preload callbacks fetch updates 2021 08 18

Mickagd · 2021-08-20T16:02:15Z

We have updated our PR with your last changes.
There is a lot of people that need these changes.
Could you please merge this request @DylanVann ?
Thanks a lot !

nguyenphucbao68 · 2021-08-30T03:39:10Z

Please merge this PR. I really need it 👍

Flictuum · 2022-01-25T13:41:43Z

Hi guys just a last call if it's possible to merge this PR, we invested time here to bring last changes to the PR and I think this will help a lot of people.
So I hope my words will find you @DylanVann
Thanks a lot for your work and maybe we could help to maintain this package for other needs !

nicomontanari · 2022-01-31T14:21:03Z

src/index.tsx

@@ -14,7 +13,7 @@ import {
    ViewProps,
 } from 'react-native'

-const FastImageViewNativeModule = NativeModules.FastImageView


This line should remain because it is needed to use "clearMemoryCache" and "clearDiskCache". It also generate a typescript error.

putuoka · 2022-05-20T07:25:17Z

how to implement this into my project? because i don't have src folder in my node_modules fast image

nicomontanari · 2022-05-20T08:42:41Z

Hi @putuoka, did you download the stable version of the package or did you download it from this pull request?

If you have downloaded the stable version in your node_modules folder you should see the compiled package in the dist folder, if not you should see the entire project as the below image:

putuoka · 2022-05-20T09:22:04Z

Hi @putuoka, did you download the stable version of the package or did you download it from this pull request?

If you have downloaded the stable version in your node_modules folder you should see the compiled package in the dist folder, if not you should see the entire project as the below image:

Hi @nicomontanari , thanks for the reply. i have downloaded stable version using yarn add react-native-fast-image
what i mean is, in this pull request there is 12 files change one of them is PreloaderManager.tsx which i can't find in my node_modules react-native-fast-image

sorry because i'm new with rn i might missing something here. sorry for my english. please enlighten me because i need to use preload promise/callback to know when it done downloading resources and then i can use it as cache with fast images & redux persist

nicomontanari · 2022-05-20T13:38:05Z

@putuoka you need to install this package with yarn add DylanVann/react-native-fast-image#pull/437/head or npm install DylanVann/react-native-fast-image#pull/437/head if you use npm

putuoka · 2022-05-23T03:32:32Z

@putuoka you need to install this package with yarn add DylanVann/react-native-fast-image#pull/437/head or npm install DylanVann/react-native-fast-image#pull/437/head if you use npm

Hi @nicomontanari i got this error:


error: Error: While trying to resolve module `react-native-fast-image` from file `D:\gcp-app\src\MainApp.js`, the package 
`D:\gcp-app\node_modules\react-native-fast-image\package.json` was successfully found. However, this package itself 
specifies a `main` module field that could not be resolved (`D:\gcp-app\node_modules\react-native-fast-image\dist\index.cjs.js`. 
Indeed, none of these files exist:

edit: run yarn upgrade --latest into node_modules fast image after that run yarn build i solve that error by doing this but still can't use new preload.

solved!! it's working!! here what i do:

clone original repo not from this pull request
run yarn install no need upgrade to latest. after that changes necessary files according to this pull request.
run yarn build copy "dist" folder to your destination node_modules which has original install of this package

note: it can't preload 151 images. sometimes just 32, sometimes 113

putuoka · 2022-05-25T09:36:15Z

Btw This pull make FastImage.clearDiskCache() broken

TypeError: Cannot read property 'clearDiskCache' of null

code:

FastImage.clearDiskCache().then(() => {
      //preloadComplete(isComplete);
      console.log('clear');
    });

patissier-boulanger · 2022-08-05T11:38:27Z

really need this!

knro · 2022-10-23T10:41:38Z

Any plans yet to merge this? Any forks that have this merged with upstream?

AlessandroAries · 2023-03-22T13:53:41Z

Any plans yet to merge this? Any forks that have this merged with upstream?

I added the changes to my fork with the updated stream: #986

skizzo · 2023-06-20T11:19:32Z

This would be so nice to have!

ymc-thzi · 2023-07-07T06:59:49Z

Had the same need, couldn't patch the PR due to conflicts. I am using another patch to get the cache folder path
With that I wrote a tiny function to get the state and even a progress of the cached images. Maybe this helps someone as a workaround...

  async function checkCacheFolder(cacheFolderPath, expectedImageCount) {
    try {
      const files = await RNFS.readDir(cacheFolderPath);
      const imageCount = files.filter(
        file => file.isFile() && file.name.endsWith('.jpg'),
      ).length;

      if (imageCount === expectedImageCount) {
        console.log('Images cache complete');
        return;
      }

      let progress = (imageCount / expectedImageCount) * 100;
      console.log(progress.toFixed(0));

      setTimeout(() => {
       checkCacheFolder(
          cacheFolderPath,
          expectedImageCount,
        );
      }, 1000);
    } catch (error) {
      //Sentry will log that
    }
  },

doomsower and others added 3 commits August 29, 2018 09:02

Add onProgress and onComplete callbacks for preload both on Android…

ead60db

… and iOS

Merge branch 'master' into preload_callbacks

5c11dec

# Conflicts: # android/src/main/java/com/dylanvann/fastimage/FastImagePreloaderModule.java # src/index.d.ts # src/index.js

Merge remote-tracking branch 'banana/preload_callbacks' into feature/…

5f9b91c

…preload-callbacks

guhungry suggested changes Mar 27, 2019

View reviewed changes

LuisRodriguezLD mentioned this pull request Mar 27, 2019

How to determine if preload completed #438

Open

fix flow

179af4c

fix: an empty sources array never called onComplete

29b01a9

Mickagd added 3 commits June 19, 2019 12:13

Merge pull request #1 from DylanVann/master

39d4cd5

Update from original repository

Merge branch 'master' into feature/preload-callbacks

4c09121

fix lint

40cb5b8

update swebimage

c86abda

Merge pull request #2 from DylanVann/master

1d93c0d

Sync with the original repo

Merge branch 'master' into feature/preload-callbacks

0f67ddb

Mickagd and others added 10 commits August 18, 2021 11:35

Merge remote-tracking branch 'upstream/master' into feature/preload-c…

3812d45

…allbacks-fetch-updates-2021-08-18

fix: revert FastImagePreloaderModule class to FastImageViewModule + a…

6dd7261

…dd callback to preload function

fix lint

70fe646

fix NativeEventEmitter mock in test

7dffb00

fix NativeEventEmitter mock in test

7dcb4ae

turn preloadermanager.js to typescript file

d7ea691

fix lint + add listener to FastImageViewModule.java

440ee83

bind context to listeners

2af79e5

add SDWebImageDownloader.h import in FFFastImagePreloaderManager.m file

f8d13ec

Merge pull request #4 from Sparted/feature/preload-callbacks-fetch-up…

bbe6c9d

…dates-2021-08-18 Feature/preload callbacks fetch updates 2021 08 18

Merge branch 'main' into feature/preload-callbacks

0ee6e1f

nicomontanari suggested changes Jan 31, 2022

View reviewed changes

nicomontanari mentioned this pull request May 20, 2022

Need FastImage Preload Promise to know when preload done to download all images #899

Open

Sparted closed this by deleting the head repository Jul 17, 2023

nicomontanari mentioned this pull request Jul 17, 2023

feat:preload callbacks #995

Open

Feature/preload callbacks #437

Feature/preload callbacks #437

Conversation

Mickagd commented Mar 26, 2019

guhungry left a comment

Choose a reason for hiding this comment

guhungry Mar 27, 2019

Choose a reason for hiding this comment

codecov bot commented Mar 28, 2019 • edited Loading

Codecov Report

RWOverdijk commented May 13, 2019

augustbjornberg commented May 17, 2019

Ilphrin commented May 28, 2019

SamiChab commented Jun 12, 2019

RWOverdijk commented Jun 19, 2019

LuisRodriguezLD commented Aug 21, 2019

RWOverdijk commented Aug 21, 2019

RWOverdijk commented Oct 12, 2019

Elindorath commented Oct 15, 2019

RWOverdijk commented Oct 15, 2019 • edited Loading

joan-saum commented Nov 4, 2019

sebqq commented Nov 5, 2019

RWOverdijk commented Nov 5, 2019

sebqq commented Nov 11, 2019

RWOverdijk commented Nov 11, 2019

sebqq commented Nov 11, 2019

RWOverdijk commented Jan 23, 2020

Mickagd commented Aug 20, 2021

nguyenphucbao68 commented Aug 30, 2021

Flictuum commented Jan 25, 2022

nicomontanari Jan 31, 2022

Choose a reason for hiding this comment

putuoka commented May 20, 2022

nicomontanari commented May 20, 2022

putuoka commented May 20, 2022

nicomontanari commented May 20, 2022

putuoka commented May 23, 2022 • edited Loading

putuoka commented May 25, 2022

patissier-boulanger commented Aug 5, 2022

knro commented Oct 23, 2022

AlessandroAries commented Mar 22, 2023

skizzo commented Jun 20, 2023

ymc-thzi commented Jul 7, 2023

codecov bot commented Mar 28, 2019 •

edited

Loading

RWOverdijk commented Oct 15, 2019 •

edited

Loading

putuoka commented May 23, 2022 •

edited

Loading