Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Setup iOS pages with initial state #188

Merged
merged 6 commits into from
Jul 24, 2023
Merged

Conversation

ry-itto
Copy link
Member

@ry-itto ry-itto commented Jun 13, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 13, 2023

Test Results

14 tests   14 ✔️  1m 19s ⏱️
  4 suites    0 💤
  4 files      0

Results for commit c00ccbf.

♻️ This comment has been updated with latest results.

]
),

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanna space between ios feature module and libraries.
what do you think?

@ry-itto ry-itto marked this pull request as ready for review July 11, 2023 01:18
Copy link
Contributor

@RyuNen344 RyuNen344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L G t M

:go: :go:

Copy link
Contributor

@tkhs0604 tkhs0604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

import Timetable

enum Tab {
case timeline
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nits]
timetable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I'll rename this with another PR!

state = .loading
}
do {
let timetable = try await FakeSessionsApi().sessions()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This too 🙏🏼

@ry-itto ry-itto merged commit d280376 into main Jul 24, 2023
6 checks passed
@ry-itto ry-itto deleted the ios-setup-initial-page branch July 24, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants