-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Setup iOS pages with initial state #188
Conversation
] | ||
), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanna space between ios feature module and libraries.
what do you think?
6b84c95
to
e774b4c
Compare
95cb7b3
to
d030323
Compare
4466ce0
to
2ae5966
Compare
2ae5966
to
c00ccbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L G t M
:go: :go:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
import Timetable | ||
|
||
enum Tab { | ||
case timeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nits]
timetable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! I'll rename this with another PR!
state = .loading | ||
} | ||
do { | ||
let timetable = try await FakeSessionsApi().sessions() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sessions()
was renamed to timetable()
ee61d39#diff-f8b250227c2be377950003f19b299b7f3325f9e8a1ba951321846b9bf070f23cL7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This too 🙏🏼
No description provided.