If today matches the opening date, scroll to that day. #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sys1yagi
commented
Mar 10, 2017
| @Override | ||
| public void onGlobalLayout() { | ||
| binding.recyclerView.getLayoutManager().scrollToPosition(position); | ||
| binding.recyclerView.getViewTreeObserver().removeOnGlobalLayoutListener(this); |
There was a problem hiding this comment.
Is there a better way? 🤔
There was a problem hiding this comment.
Sorry, I don't know why OnGlobalLayoutListener is needed 🙇
Is it enough just to call binding.recyclerView.getLayoutManager().scrollToPosition(position); ?
sys1yagi
changed the title
sys1yagi
force-pushed
the
scroll_to_the_date
branch
from
b7ba24b
to
7887630
Compare
sys1yagi
commented
Mar 10, 2017
| .indexed() | ||
| .filter(pair -> todayString.equals(pair.getSecond())) | ||
| .findFirst() | ||
| .orElse(new IntPair<>(0, "")) |
There was a problem hiding this comment.
If there is no match, position 0 is returned.
There was a problem hiding this comment.
Is it better to use Stream? In this case, just for loop seems easy. What do you think?
for (int i = 0; i<= adjustedSessionViewModels.size(); i++) {
SessionViewModel viewModel = adjustedSessionViewModels.get(i);
if (todayString.equals(viewModel.getFormattedDate()) {
return i;
}
return 0;
}
|
👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
None
Overview (Required)
If today matches the opening date, scroll to that day.
Links
Screenshot