Show local time on/Off + Device Time Zone Change #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DroidKaigi#198 ## Desc - Add, ThreeTenABP - Add, Gson Custom TypeAdapter (ZonedDateTimeSerializer, ZonedDateTimeDeserializer) - Change Data type Date -> ZonedDateTime (Session stime/etime)
- Support, Device Zone Change - Support, Display Time On/Off
# Conflicts: # app/src/main/java/io/github/droidkaigi/confsched2017/viewmodel/SessionViewModel.java # app/src/main/java/io/github/droidkaigi/confsched2017/viewmodel/SessionsViewModel.java
|
👀 |
|
Thanks for contribution! 😄 |
|
it's ok. |
|
Sorry to be late 🙇 |
|
^^ no problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Session#stime / Session#etimechanges fromDatetoZonedDateTime.Since Date has GMT, it turned out that the value changes depending on the time zone of the device.
#198 (comment)
So we added processing below.
com.jakewharton.threetenabp:threetenabp:1.0.5Asia/TokyoTimeZoneAsia/TokyoTimeZoneBy using the above,
Session#stime / Session#etimecertainly maintains the state ofAsia/Tokyo.Also, we will process it using the current location on/off and timezone in
LocaleUtil#getDisplayDate.Please note that GMT is forcibly modified by time zone.
I'm sorry. The commit log became cluttered due to various trials. 🙇 🙇 🙇
Links
Screenshot