Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minecart/boat stopping on collide with vanished player #25

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

MrNavaStar
Copy link
Contributor

Minecarts and boats stop moving if they collide with a vanished player. This mixin fixes that (for both, even tho its only in the boat class... Mojang why...)

  • Note: If the player in the boat can see vanished players, they will still collide on the client (but not on the server). Not really sure if there is a way to fix that, but I don't think its a big concern since you can see the thing your running into. This doesn't seem to effect minecarts at all.

@MrNavaStar
Copy link
Contributor Author

Just realized this should probably be tied to one of the interaction configs, will update tomorrow.

@DrexHD DrexHD merged commit 22d7137 into DrexHD:1.20/stable Oct 4, 2023
1 check passed
@MrNavaStar MrNavaStar deleted the moving-boats/carts-fix branch October 4, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants