Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce compiler warnings (-Wall -Wpedantic) #880

Open
wants to merge 9 commits into
base: dev2
Choose a base branch
from

Conversation

gruenich
Copy link
Contributor

No description provided.

DrTimothyAldenDavis and others added 9 commits August 11, 2024 09:29
SuiteSparse 7.8.1: update to GraphBLAS 9.3.1
Bumps [Jimver/cuda-toolkit](https://github.com/jimver/cuda-toolkit) from 0.2.16 to 0.2.18.
- [Release notes](https://github.com/jimver/cuda-toolkit/releases)
- [Commits](Jimver/cuda-toolkit@v0.2.16...v0.2.18)

---
updated-dependencies:
- dependency-name: Jimver/cuda-toolkit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…ependabot/github_actions/Jimver/cuda-toolkit-0.2.18

Bump Jimver/cuda-toolkit from 0.2.16 to 0.2.18
Extra semicolons are forbidden outside a function.
Found by GCC 15 (Wpedantic)
In release builds the asserts are removed and the
compiler warns about the unused variables.
This can only be done with C++ (and C 23).
Found by GCC 15 (Wunused-but-set-variable)
@DrTimothyAldenDavis
Copy link
Owner

Looks good. I haven't had time to try these out but will do so when my schedule allows.

My organization requires a minor revision to my Contributor Agreement, for all new contributions. Can you sign the new one I just posted? It's here in the dev branch:

https://github.com/DrTimothyAldenDavis/SuiteSparse/blob/dev/Contributor_License/SuiteSparse%20Individual%20Contributor%20License%20Agreement%20(20241011).pdf

@DrTimothyAldenDavis
Copy link
Owner

Also, I need to revise the PR to go to the dev2 branch, not dev. The two branches are in sync so that shouldn't be a problem.

@DrTimothyAldenDavis DrTimothyAldenDavis changed the base branch from dev to dev2 November 4, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants