-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce compiler warnings (-Wall -Wpedantic) #880
Open
gruenich
wants to merge
9
commits into
DrTimothyAldenDavis:dev2
Choose a base branch
from
gruenich:feature/reduce-compiler-warnings
base: dev2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Reduce compiler warnings (-Wall -Wpedantic) #880
gruenich
wants to merge
9
commits into
DrTimothyAldenDavis:dev2
from
gruenich:feature/reduce-compiler-warnings
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuiteSparse 7.8.1: update to GraphBLAS 9.3.1
For SuiteSparse 7.8.2
Bumps [Jimver/cuda-toolkit](https://github.com/jimver/cuda-toolkit) from 0.2.16 to 0.2.18. - [Release notes](https://github.com/jimver/cuda-toolkit/releases) - [Commits](Jimver/cuda-toolkit@v0.2.16...v0.2.18) --- updated-dependencies: - dependency-name: Jimver/cuda-toolkit dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…ependabot/github_actions/Jimver/cuda-toolkit-0.2.18 Bump Jimver/cuda-toolkit from 0.2.16 to 0.2.18
ParU 1.0.0 for SuiteSparse 7.8.3
Extra semicolons are forbidden outside a function. Found by GCC 15 (Wpedantic)
In release builds the asserts are removed and the compiler warns about the unused variables. This can only be done with C++ (and C 23). Found by GCC 15 (Wunused-but-set-variable)
Found by GCC (Wenum-int-mismatch)
Found by Clang 19
Looks good. I haven't had time to try these out but will do so when my schedule allows. My organization requires a minor revision to my Contributor Agreement, for all new contributions. Can you sign the new one I just posted? It's here in the dev branch: |
Also, I need to revise the PR to go to the dev2 branch, not dev. The two branches are in sync so that shouldn't be a problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.