sync dev2 and paru_dev2 #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParU get/set
Clang 17 emits more warnings (or errors) when it comes to incompatible pointer types. `_InterlockedCompareExchange` is declared with `long volatile *` as the type of its first input argument See: https://learn.microsoft.com/en-us/cpp/intrinsics/interlockedcompareexchange-intrinsic-functions?view=msvc-170 `int32_t` is `int` on Windows. While `long` and `int` have the same size on Windows (LLP64 data model), they are technically distinct types. Avoid the compiler warning by casting to the pointer type expected by that function.
GraphBLAS: Avoid warning from Clang 17.
Avoid including headers in extern "C" blocks
CI: Add runner that builds MSVC target with `clang`/`clang++`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The paru_dev2 branch is a working branch for major changes to ParU. Most of those are done so I think I can delete paru_dev2 soon. In the meantime, sync it with the main development branch, dev2.