SPEX: Account for SUITESPARSE_USE_STRICT when using SPEX_USE_PYTHON #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle SPEX_USE_PYTHON similar to SPEX_USE_OPENMP when SUITESPARSE_USE_STRICT is ON.
Do not default to building Python interface if not building shared libraries.
|
The latest commit uses a default value of What do you think? |
|
Re-opening to trigger the CI again. The issue with the package signatures from Alpine Linux should be fixed now: |
|
Looks great -- thanks! |
DrTimothyAldenDavis
merged commit 43cdafc
into
DrTimothyAldenDavis:dev2
47 of 50 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle SPEX_USE_PYTHON similar to SPEX_USE_OPENMP when SUITESPARSE_USE_STRICT is ON.
Another addendum to #805.