GraphBLAS: Limit scope of extern "C" block to function declarations. #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Headers shouldn't be included in extern "C" blocks. These blocks are only really needed for function definitions. Limit the scope of the extern "C" block in GraphBLAS.h to where is really needed.
mmuetzel
referenced
this pull request
May 23, 2024
mmuetzel
changed the title
DrTimothyAldenDavis
merged commit 9bb54f1
into
DrTimothyAldenDavis:paru_dev2
23 of 25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Headers (especially headers from the standard library) shouldn't be included in extern "C" blocks. These blocks are only really needed for function declarations.
Limit the scope of the extern "C" block in GraphBLAS.h to where it's really needed.
This should hopefully avoid the build error when using LLVM
libc++as the standard library.