Example: Don't include OpenMP header if building without it. #809
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include
omp.h
only if_OPENMP
is defined.This fixes an issue when trying to build the example on a system on which no OpenMP implementation can be detected by CMake.
Afaict, the example doesn't use any OpenMP features directly. So, it shouldn't be necessary at all to include the OpenMP header. If a library requires that the OpenMP header is included, that library should include it in its own header.
Should including
omp.h
in the header of the example be removed entirely?