Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParU: Explicitly include <cinttypes> in header that uses PRId64 #772

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

mmuetzel
Copy link
Contributor

@mmuetzel mmuetzel commented Mar 6, 2024

Potentially fixes #769.

@mmuetzel
Copy link
Contributor Author

mmuetzel commented Mar 6, 2024

The build error for one of the demos of the SPEX library seems to be unrelated to this change.

@DrTimothyAldenDavis
Copy link
Owner

I see the problem in SPEX. An openmp for loop had for (int id = ...) where the value id is declared in the for loop itself. I just fixed it.

SPEX (to become v3.1) needs a threadprivate variable (via OpenMP or at __threads keyword) for thread safety (see

// SPEX is thread-safe as long as all of the following conditions hold:
), and spex_demo_threaded is a new demo program that tests this.

@DrTimothyAldenDavis DrTimothyAldenDavis merged commit 8c59a72 into DrTimothyAldenDavis:dev2 Mar 6, 2024
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants