-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add runner that builds MSVC target with clang
/clang++
#760
CI: Add runner that builds MSVC target with clang
/clang++
#760
Conversation
The (upstream) issue is that the OpenMP libraries aren't set for some reason by
IIUC, they should be set to the same as when building with
|
The following change to the file provided by CMake fixes the issue for me locally: diff --git a/Modules/FindOpenMP.cmake b/Modules/FindOpenMP.cmake
index 69099f7620..a311b915dd 100644
--- a/Modules/FindOpenMP.cmake
+++ b/Modules/FindOpenMP.cmake
@@ -224,7 +224,8 @@ function(_OPENMP_GET_FLAGS LANG FLAG_MODE OPENMP_FLAG_VAR OPENMP_LIB_NAMES_VAR)
OUTPUT_VARIABLE OpenMP_TRY_COMPILE_OUTPUT
)
- if(OpenMP_COMPILE_RESULT_${FLAG_MODE}_${OPENMP_PLAIN_FLAG})
+ if(OpenMP_COMPILE_RESULT_${FLAG_MODE}_${OPENMP_PLAIN_FLAG} AND
+ NOT CMAKE_${LANG}_SIMULATE_ID STREQUAL "MSVC")
set("${OPENMP_FLAG_VAR}" "${OPENMP_FLAG}" PARENT_SCOPE)
if(CMAKE_${LANG}_VERBOSE_FLAG) I don't know if this is the correct change though or if this might break something else. |
#761 would probably fix the build error where it is failing currently. |
d62f246
to
1efdccd
Compare
With the last experiment, the OpenMP libraries are detected correctly also for the runner that uses
|
1efdccd
to
30a005d
Compare
Rebased to check if this is fixed in the CMake version |
30a005d
to
f52567f
Compare
It looks like this is working with the versions of MSVC, Clang, and CMake on the current GitHub runner images:
Converted from draft to "ready for review". |
5411c96
into
DrTimothyAldenDavis:dev2
This is just to demonstrate the issue discussed in #750.
The issue probably needs a fix in upstream CMake (not in SuiteSparse). Please, do not merge (until this is fixed upstream and the fix made its way to Visual Studio).