Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphBLAS: Disable JIT compiler by default when cross-compiling. #730

Closed
wants to merge 1 commit into from

Conversation

mmuetzel
Copy link
Contributor

I was hoping that users that cross-compile libraries to a different target understand their toolchains. But that doesn't seem to be the case generally.
To improve the out-of-the-box experience for those users, disable the JIT compiler by default when cross-compiling. Interested users could still enable it (and supply settings for a working native toolchain).

@mmuetzel mmuetzel changed the title GraphBLAS: Disable JIT by default when cross-compiling. GraphBLAS: Disable JIT compiler by default when cross-compiling. Jan 12, 2024
@DrTimothyAldenDavis
Copy link
Owner

The JIT is extremely important for performance. Cross-compiling is something not done by a typical user, but by someone who should know how to use toolchains on both the host and the target. I'd rather have them try to get the JIT to work, and in the worst case, if they can't get it to work then they can select a non-default option to turn off the JIT.

@mmuetzel
Copy link
Contributor Author

That sounds reasonable. We probably just have to live with users that come with unreasonable expectations.

@mmuetzel mmuetzel closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants