CHOLMOD: Use object libraries to simplify source. #717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many files in CHOLMOD are built multiple times with different preprocessor macros. This is currently done with stub files that define a macro and then include a file with the actual code.
Avoid using those stub files by compiling the same source file multiple times with different flags using CMake object libraries.
I don't know if this is something that is acceptable. I haven't done many checks with these changes. So, keeping as draft for now.