Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHOLMOD: Use object libraries to simplify source. #717

Closed
wants to merge 1 commit into from

Conversation

mmuetzel
Copy link
Contributor

@mmuetzel mmuetzel commented Jan 9, 2024

Many files in CHOLMOD are built multiple times with different preprocessor macros. This is currently done with stub files that define a macro and then include a file with the actual code.

Avoid using those stub files by compiling the same source file multiple times with different flags using CMake object libraries.

I don't know if this is something that is acceptable. I haven't done many checks with these changes. So, keeping as draft for now.

@DrTimothyAldenDavis
Copy link
Owner

I'd prefer to leave the setup as-is, so that each file is compiled just once. It works, I understand it, and changing it would cause a lot of changes in all of SuiteSparse (I use this strategy in many packages). I'm concerned that I would end up with build system that I might not be able to revise or understand.

@DrTimothyAldenDavis
Copy link
Owner

This change would also break my CHOLMOD/Tcov tests, which doesn't use cmake at all and requires these files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants