Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example: Remove explicit import of transient dependencies. #659

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

mmuetzel
Copy link
Contributor

That should no longer be needed. And removing them should allow the CI to check if the CMake Config files are complete.

That should no longer be needed. And removing them should allow the CI
to check if the CMake Config files are complete.
@DrTimothyAldenDavis DrTimothyAldenDavis merged commit 186bc72 into DrTimothyAldenDavis:dev2 Dec 30, 2023
23 checks passed
@DrTimothyAldenDavis
Copy link
Owner

Looks great -- thanks.

@DrTimothyAldenDavis
Copy link
Owner

I'm seeing errors when building the Example when not using the top level CMakeLists.txt. After "make local ; make install ; cd Example ; make" I get:

CMake Error at /home/davis/dev2/SuiteSparse/lib/cmake/ParU/ParUTargets.cmake:62 (set_target_properties):
  The link interface of target "SuiteSparse::ParU_static" contains:

    OpenMP::OpenMP_CXX

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Call Stack (most recent call first):
  /home/davis/dev2/SuiteSparse/lib/cmake/ParU/ParUConfig.cmake:121 (include)
  CMakeLists.txt:104 (find_package)

@mmuetzel
Copy link
Contributor Author

Looking into it.

@mmuetzel
Copy link
Contributor Author

PR #662 should fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants