Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphBLAS: Generate GB_JITpackage.c only if included files have changed. #602

Merged
merged 5 commits into from
Dec 19, 2023

Conversation

mmuetzel
Copy link
Contributor

@mmuetzel mmuetzel commented Dec 19, 2023

This avoids relinking libgraphblas if nothing actually changed.
And in turn that avoids re-linking everything when calling make demos for LAGraph.

This might help to avoid the linker being stuck sometimes when relinking the LAGraph binaries on macOS (for an unknown reason).

@mmuetzel
Copy link
Contributor Author

The macos runner failed with the following error while installing the dependencies from homebrew:

==> sbt
You can use $SBT_OPTS to pass additional JVM options to sbt.
Project specific options should be placed in .sbtopts in the root of your project.
Global settings should be placed in /usr/local/etc/sbtopts

The installation does not include `sbtn`.
Error: Process completed with exit code 1.

I don't know what that means.

@mmuetzel
Copy link
Contributor Author

mmuetzel commented Dec 19, 2023

The actual error might be this:

==> Pouring [email protected]
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/2to3-3.12
Target /usr/local/bin/2to3-3.12
already exists. You may want to remove it:
  rm '/usr/local/bin/2to3-3.12'

To force the link and overwrite all conflicting files:
  brew link --overwrite [email protected]

To list all files that would be deleted:
  brew link --overwrite --dry-run [email protected]

Possible conflicting files are:
/usr/local/bin/2to3-3.12 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/2to3-3.12
/usr/local/bin/idle3.12 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/idle3.12
/usr/local/bin/pydoc3.12 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/pydoc3.12
/usr/local/bin/python3.12 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/python3.12
/usr/local/bin/python3.12-config -> /Library/Frameworks/Python.framework/Versions/3.12/bin/python3.12-config

Edit: Should be fixed by forcing the installation of Python 3.12

@DrTimothyAldenDavis
Copy link
Owner

Yes, this would be better. I just couldn't figure out how to get it to work.

@DrTimothyAldenDavis DrTimothyAldenDavis merged commit 8017451 into DrTimothyAldenDavis:dev2 Dec 19, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants