Overhaul build rules with recent lessons learned. #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll check it shortly. Getting close to SuiteSparse 7.4.0.beta1. Your help has been amazing! |
|
Please, wait a couple of minutes before merging. |
|
The typos should be fixed now. |
|
Giving it a try now. I've added methods to all my packages that return the 3 version numbers. Some of my packages already had these, like cholmod_version. I haven't posted it yet (I'll merge this in first). |
DrTimothyAldenDavis
merged commit f8748ca
into
DrTimothyAldenDavis:dev2
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt build rules with changes that were needed for CHOLMOD and UMFPACK.
@DrTimothyAldenDavis: I don't know if this will fix the remaining issue with SPEX. But maybe you could give this a try?