UMFPACK: Avoid non-POSIX flags for diff in make demos target
#511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag `--strip-trailing-cr` is a non-standard flag for `diff` and isn't supported on Alpine Linux. Try to use commands that work across POSIX-compatible platforms.
DrTimothyAldenDavis
merged commit 3a0fffb
into
DrTimothyAldenDavis:dev2
22 checks passed
|
At some point I need to turn all these short demos into cmake tests. |
mmuetzel
added a commit
to mmuetzel/SuiteSparse
that referenced
this pull request
Jan 2, 2024
The flag `--strip-trailing-cr` is a non-standard flag for `diff` and isn't supported on Alpine Linux. Try to use commands that work across POSIX-compatible platforms. See also DrTimothyAldenDavis#511.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag
--strip-trailing-cris a non-standard flag todiffand isn't supported by that application on Alpine Linux. Try to use commands that work across POSIX-compatible platforms.I also opted to use
diff -ubecause I'm more used to reading git diffs. I hope it's ok to change the format of the output.