GraphBLAS: Fix include directory of static library in build tree #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only an issue when trying to link to the GraphBLAS_static CMake target before it is installed. No functional change for that target after it is installed. Missed in e1c7e4e
DrTimothyAldenDavis
merged commit f40fc8a
into
DrTimothyAldenDavis:dev2
22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only an issue when trying to link to the GraphBLAS_static CMake target before it is installed. No functional change for that target after it is installed.
I missed that part in e1c7e4e. Sorry for that.
This fixes the issue discovered in #500. For a test, I switched building the static libraries of GraphBLAS ON in CI. And the build succeeded.