Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LAGraph: Use memmove when condensing array Tj. #473

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

mmuetzel
Copy link
Contributor

@mmuetzel mmuetzel commented Oct 29, 2023

Use memmove (or if available memmove_s) instead of for loop.
That could be using a potentially more efficient implementation to do that job.

See also #461.

Use `memmove` (or if available `memmove_s`) instead of `for` loop.
@DrTimothyAldenDavis DrTimothyAldenDavis merged commit a5366aa into DrTimothyAldenDavis:dev2 Oct 29, 2023
17 checks passed
@DrTimothyAldenDavis
Copy link
Owner

Thanks. I commented out the memmove_s, since at this point in the code, I know that it won't copy anything outside the limits of the array, and the pointers for the source and destination cannot be NULL. That would be caught earlier in the call to GxB_Matrix_unpack_CSR, which creates Tj as non-NULL or returns a failure code that is then caught by the GRB_TRY(...).

@mmuetzel
Copy link
Contributor Author

mmuetzel commented Oct 29, 2023

For later reference: @DrTimothyAldenDavis is likely referring to this change:
26d4afb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants