Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Make sure that "with" doesn't match "without" in ccache key #422

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

mmuetzel
Copy link
Contributor

I was wondering why some runners took exceptionally long compared to others sometimes.
Turns out that is because "with" can match "without" in the restore key for the GitHub cache that's used for ccache. (Didn't think of that 😖)

Make sure that doesn't happen by adding ":" to the affected restore keys.

This is a low-impact change that shouldn't affect the release process.

@mmuetzel mmuetzel changed the base branch from dev to dev2 September 19, 2023 17:52
@DrTimothyAldenDavis
Copy link
Owner

Ah, yes, I was wonder about that. I'll add this to dev2 and dev right away.

@DrTimothyAldenDavis DrTimothyAldenDavis merged commit aae40c9 into DrTimothyAldenDavis:dev2 Sep 19, 2023
16 checks passed
@DrTimothyAldenDavis
Copy link
Owner

I've run out of run time that GitHub provides for CI. It resets Oct 15th, unless I pay for more time. This change will help reduce the time it takes to do the CI. Too late for this month's cycle, unfortunately.

@mmuetzel
Copy link
Contributor Author

I've run out of run time that GitHub provides for CI. It resets Oct 15th, unless I pay for more time.

Is there a limit for the maximum runtime for open source projects? I didn't run into that before.
I'd understand their documentation that hosted runners are free to use for open source projects:
https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration

Could you please show a screenshot of that error message?

@DrTimothyAldenDavis
Copy link
Owner

Oh, I must have hit that limit on an unrelated private repo just now.

No worries then. The private repo doesn't need CI.

@DrTimothyAldenDavis
Copy link
Owner

I think the run time used for open source repos must be free, but the time it uses for that is subtracted from time available for non-open repos. So this update will help that.

However, I don't really need CI on this private repo anyway.

@mmuetzel
Copy link
Contributor Author

Sorry if I'm stupid. Which private repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants