Mongoose: Link executables to SuiteSparse_Config that depend on it #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix! |
DrTimothyAldenDavis
merged commit 5ffb460
into
DrTimothyAldenDavis:dev
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests or demos in the Mongoose project use functions from SuiteSparse_Config.
When linking statically, that dependency happens to be pulled in via Mongoose_static. But when linking dynamically, that dependency doesn't happen to be pulled in "by chance".
Link target for executables that are using functions from SuiteSparse_Config explicitly to the respective target. (The build rules in that project seem to prefer static over shared linking. So, do the same here.)
Fixes #406.