Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to build system (part 2; cuda) #400

Merged
merged 5 commits into from
Sep 14, 2023
Merged

updates to build system (part 2; cuda) #400

merged 5 commits into from
Sep 14, 2023

Conversation

DrTimothyAldenDavis
Copy link
Owner

No description provided.

@mmuetzel
Copy link
Contributor

mmuetzel commented Sep 13, 2023

find_package ( ... REQUIRED ) inside a Config.cmake file doesn't do the right thing if the target is imported without the REQUIRED flag in a downstream project.
But we are currently using this idiom, e.g., to import the CUDAToolkit (and other targets that should be "transparent" to a user).

I've an idea how to improve that. But it's getting late here. I'll try to open a PR tomorrow.
Could you please wait another day before tagging the next beta?

@DrTimothyAldenDavis
Copy link
Owner Author

Sure -- I'm in no rush to tag a new beta release.

@mmuetzel
Copy link
Contributor

I opened #402 for that change.

@DrTimothyAldenDavis
Copy link
Owner Author

OK. I'll merge both in -- thanks.

@DrTimothyAldenDavis DrTimothyAldenDavis merged commit 9b5b5a5 into dev Sep 14, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants