Fix pkg-config files on platforms without import libraries. #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is all but Windows.
|
Sure -- I can add this to SuiteSparse v7.2.0. It's still a beta release, so I'll just make a v7.2.0.beta4. |
DrTimothyAldenDavis
merged commit 299427f
into
DrTimothyAldenDavis:dev2
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stripping the file extension from the library names doesn't work correctly on platforms where
CMAKE_IMPORT_LIBRARY_SUFFIXis empty. That is all but Windows.This PR fixes that issue by checking for the file extension
CMAKE_IMPORT_LIBRARY_SUFFIXonly on Windows.It would be nice if this change could still make it into 7.2.0.