Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuiteSparse v7.2.0.beta1 #380

Merged
merged 241 commits into from
Sep 8, 2023
Merged

SuiteSparse v7.2.0.beta1 #380

merged 241 commits into from
Sep 8, 2023

Conversation

DrTimothyAldenDavis
Copy link
Owner

@DrTimothyAldenDavis DrTimothyAldenDavis commented Sep 5, 2023

Sept 8, 2023: version 7.2.0 (BETA1)

* build system: modern cmake structure, by Markus Muetzel.
    Most packages updated to vX.2.0 where X is unchanged (except SPQR
    and Example package).
* SPQR v4.2.0: Major SO update.  Support for int32 indices by Raye Kimmerer

rayegun and others added 30 commits May 11, 2023 00:04
Also only link to static library if it was actually built.
CI: Add runners that build with CUDA on Ubuntu
CI: Use ccache also for CUDA compiler.
Don't generate .pc files for MSVC compatible tool chains.
CHOLMOD: Don't include external headers in `extern "C"` block.
Use targets more consistently instead of variables.
Set properties on the target instead of globally where possible.
No need for a CUDA compiler for the sources of SPQR.
There are no OpenMP accelerated expressions in the sources. So, don't depend on OpenMP.
Don't link transient targets of CHOLMOD (AMD and COLAMD) explicitly.
Link static libraries to static libraries if possible.
SPQR might use OpenMP in the future. By default, OpenMP is disabled for
now to avoid over-linking.
SPQR: Overhaul CMake build rules.
@DrTimothyAldenDavis DrTimothyAldenDavis merged commit 0ddf46e into dev Sep 8, 2023
15 checks passed
@mmuetzel
Copy link
Contributor

mmuetzel commented Sep 8, 2023

There seems to be a build issue when CHOLMOD is configured with NOPENMP.
I guess that moving SuiteSparse__thread.cmake to the cmake_modules folder inside SuiteSparse_config might fix it. But I haven't tested that yet.

Is there a reason why it's not in the same folder as the other .cmake files?

@DrTimothyAldenDavis
Copy link
Owner Author

oops! That's an oversight. It should be inside the SuiteSparse_config/cmake_modules subfolder. I'll move it there now and post a 7.2.0.beta2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants