Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add runners that build with CUDA on Ubuntu #378

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

mmuetzel
Copy link
Contributor

@mmuetzel mmuetzel commented Sep 4, 2023

This extends the matrix for the Ubuntu runners to include builds with and without CUDA.

I hope that will be useful in testing.

@mmuetzel
Copy link
Contributor Author

mmuetzel commented Sep 4, 2023

The workaround for nvlink is needed because those three libraries are empty on Ubuntu. nvlink seems to require that a static library consists of at least one object file (even if that object file is empty).
According to internet sources, this is fixed in newer versions of nvlink. Version 11.7 is reported to work correctly with those original empty libraries. But Ubuntu 22.04 distributes version 11.5.

Maybe, that work-around can be removed when the CI on GitHub switches to Ubuntu 24.04 (probably some time next year).

@DrTimothyAldenDavis
Copy link
Owner

Awesome -- thanks. I'll merge it as soon as the checks complete.

@DrTimothyAldenDavis
Copy link
Owner

I'm currently working on SPQR, by adding the test coverage suite for 32-bit integers added by @Wimmerer. A few changes to CHOLMOD to support that update, as well. Those changes shouldn't conflict with these changes to the build.yaml.

@DrTimothyAldenDavis DrTimothyAldenDavis merged commit d51c90f into DrTimothyAldenDavis:dev2 Sep 4, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants