Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPURuntime: Don't add include dir for SuiteSparse_Config to interface #370

Merged
merged 1 commit into from
Aug 30, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions SuiteSparse_GPURuntime/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,8 @@ set_target_properties ( GPURuntime PROPERTIES

target_include_directories ( GPURuntime PRIVATE
${CUDAToolkit_INCLUDE_DIRS}
${SUITESPARSE_GPURUNTIME_INCLUDES} )

target_include_directories ( GPURuntime PUBLIC
"$<TARGET_PROPERTY:SuiteSparse::SuiteSparseConfig,INTERFACE_INCLUDE_DIRECTORIES>" )
${SUITESPARSE_GPURUNTIME_INCLUDES}
$<TARGET_PROPERTY:SuiteSparse::SuiteSparseConfig,INTERFACE_INCLUDE_DIRECTORIES> )

if ( SUITESPARSE_CUDA )
set_target_properties ( GPURuntime PROPERTIES POSITION_INDEPENDENT_CODE ON )
Expand Down Expand Up @@ -136,10 +134,8 @@ if ( NOT NSTATIC )

target_include_directories ( GPURuntime_static PRIVATE
${CUDAToolkit_INCLUDE_DIRS}
${SUITESPARSE_GPURUNTIME_INCLUDES} )

target_include_directories ( GPURuntime_static PUBLIC
"$<TARGET_PROPERTY:SuiteSparse::SuiteSparseConfig,INTERFACE_INCLUDE_DIRECTORIES>" )
${SUITESPARSE_GPURUNTIME_INCLUDES}
$<TARGET_PROPERTY:SuiteSparse::SuiteSparseConfig,INTERFACE_INCLUDE_DIRECTORIES> )

if ( SUITESPARSE_CUDA )
set_target_properties ( GPURuntime_static PROPERTIES CUDA_SEPARABLE_COMPILATION on )
Expand Down