Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(activity): fall back to name for custom activities #1087

Merged
merged 5 commits into from
Aug 27, 2023

Conversation

shiftinv
Copy link
Member

Summary

Bots can now set a custom status using the state field in type 4 activities.

This already works using activity=CustomActivity(state="Now with 200% more bees!", name="Custom Status"), but is unnecessarily complicated. name is required but not displayed, it just has to be non-empty.
To simplify things, we now just make state fall back to name if unset, such that CustomActivity(name="...") works as-is.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature s: needs review Issue/PR is awaiting reviews labels Aug 12, 2023
@shiftinv shiftinv merged commit 0f47b37 into master Aug 27, 2023
23 of 24 checks passed
@shiftinv shiftinv deleted the fix/custom-activity-state branch August 27, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: needs review Issue/PR is awaiting reviews t: enhancement New feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant