-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #167 from Disfactory/feature/imgur-image-fallback
feat: implement ImgurFallbackImage component
- Loading branch information
Showing
4 changed files
with
66 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
VUE_APP_BASE_URL=https://staging.disfactory.tw/api | ||
VUE_APP_IMGUR_FALLBACK_URL=https://api.disfactory.tw/imgur |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,6 +66,7 @@ jobs: | |
run: | | ||
npm ci | ||
echo "VUE_APP_BASE_URL=https://staging.disfactory.tw/api" > .env | ||
echo "VUE_APP_IMGUR_FALLBACK_URL=https://staging.disfactory.tw/imgur" >> .env | ||
npm run build | ||
- name: Deploy to GitHub Pages | ||
uses: JamesIves/[email protected] | ||
|
@@ -95,6 +96,7 @@ jobs: | |
run: | | ||
npm ci | ||
echo "VUE_APP_BASE_URL=https://api.disfactory.tw/api" > .env.production | ||
echo "VUE_APP_IMGUR_FALLBACK_URL=https://api.disfactory.tw/imgur" >> .env.production | ||
npm run build | ||
echo "disfactory.tw" > dist/CNAME | ||
- name: Deploy to GitHub Pages | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
<template> | ||
<img :src="imageUrl" :alt="alt" :class="className" @error="onError" /> | ||
</template> | ||
|
||
<script lang="ts"> | ||
import { createComponent, computed, ref, onUpdated, watch } from '@vue/composition-api' | ||
const IMGUR_REGEX = /i\.imgur\.com\/([a-zA-Z0-9]+)\.([a-zA-Z0-9]+)(\?.*)?$/ | ||
const imgurFallbackBaseUrl = process.env.NODE_ENV === 'production' ? process.env.VUE_APP_IMGUR_FALLBACK_URL : '/server/imgur' | ||
export default createComponent({ | ||
name: 'ImgurFallbackImage', | ||
props: { | ||
src: { | ||
type: String, | ||
required: true | ||
}, | ||
alt: { | ||
type: String, | ||
default: '' | ||
}, | ||
className: { | ||
type: String, | ||
default: '' | ||
} | ||
}, | ||
setup (props, context) { | ||
const matches = IMGUR_REGEX.exec(props.src) | ||
const imgurInfo = computed(() => { | ||
return matches ? { | ||
id: matches[1], | ||
ext: matches[2] | ||
} : null | ||
}) | ||
const fallbackUrl = computed(() => { | ||
if (imgurInfo.value) { | ||
return `${imgurFallbackBaseUrl}/${imgurInfo.value.id}.${imgurInfo.value.ext}` | ||
} else { | ||
return props.src | ||
} | ||
}) | ||
const imageUrl = ref(fallbackUrl.value) | ||
const onError = () => { | ||
imageUrl.value = props.src | ||
} | ||
return { | ||
imageUrl, | ||
onError | ||
} | ||
} | ||
}) | ||
</script> |