Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Use grpc/grpc-web rather than impossible-eng/grpc-web #95

Closed
wants to merge 1 commit into from

Conversation

mrmeku
Copy link

@mrmeku mrmeku commented Mar 5, 2020

Hey there @Dig-Doug, this is less of an actual PR and more of a show and tell. I spent the evening taking your existing code and integrating the logic with https://github.com/grpc/grpc-web

I wasn't really sure if you'd like this effort to be a separate project or if you'd be interested in somehow making this project house the logic for both.

If you'd rather not maintain separate code paths in this project, I might want to chat with @alexeagle to upstream some of this to rules_nodejs if you were okay with that. Their existing typescript proto library is in need of a GRPC compatible replacement

Anyways, thanks so much for producing such great code! Its always nice to see a proper bazel aspect out in the wild.

@Dig-Doug
Copy link
Owner

Dig-Doug commented Mar 5, 2020

Thanks for the PR. I'm open to supporting other libraries in this repo (see #10 for more info) as long as they're interoperable with the output of the typescript_proto_library. Aka, users should be able to define a single typescript_proto_library and use it with any of the grpc services.

I'm also open to upstreaming this code if that's something they're interested in.

@mrmeku
Copy link
Author

mrmeku commented Mar 5, 2020

Awesome! I'll refactor my code a bit so that I can integrate into your repo. Then we can try to upstream it after the fact

@Jdban
Copy link

Jdban commented Mar 20, 2020

This looks awesome!

@mrmeku mrmeku closed this Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants