WIP: Use grpc/grpc-web rather than impossible-eng/grpc-web #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there @Dig-Doug, this is less of an actual PR and more of a show and tell. I spent the evening taking your existing code and integrating the logic with https://github.com/grpc/grpc-web
I wasn't really sure if you'd like this effort to be a separate project or if you'd be interested in somehow making this project house the logic for both.
If you'd rather not maintain separate code paths in this project, I might want to chat with @alexeagle to upstream some of this to
rules_nodejs
if you were okay with that. Their existing typescript proto library is in need of a GRPC compatible replacementAnyways, thanks so much for producing such great code! Its always nice to see a proper bazel aspect out in the wild.