Add grpc-node support
#134
Conversation
mc0
force-pushed
the
add_grpc_node_support
branch
from
5b65e0f
to
680bc77
Compare
| @@ -230,20 +304,54 @@ def _typescript_proto_library_impl(ctx): | |||
| ], | |||
| ) | |||
|
|
|||
| typescript_proto_library = rule( | |||
| def typescript_proto_library(name, proto): | |||
There was a problem hiding this comment.
Let's rename this file to typescript_proto_build and move this macro to another file so it matches the other two macros.
There was a problem hiding this comment.
This is what initially this had but it made reading the diff very difficult. Can we rename it as a separate PR after this one goes in?
- Refactor `typescript_proto_library` to generate only messages - Add `typescript_grpc_web_library` to provide previous functionality - Add `typescript_grpc_node_library` to add grpc-node support - Improve documentation - Add migration guide when coming from previous versions - Update `ts-protoc-gen`
mc0
force-pushed
the
add_grpc_node_support
branch
from
680bc77
to
2c29496
Compare
- Clean up minor issues
Thank you! I think I followed the nits, but let me know if there is anything else that needs changing. Also, the commit history is a bit strange since I worked on top of someone else's WIP effort. Should I rebase this and clean up the history? |
|
I squashed the commits so no need to clean up. Thanks for your work on this! I'll cut a new version too. |
|
Thanks for getting this in. |
typescript_proto_libraryto generate only messagestypescript_grpc_web_libraryto provide previous functionalitytypescript_grpc_node_libraryto add grpc-node supportts-protoc-genThis builds on the work by @Multiply.
Closes #10