Added search option to batch operations #1054
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This basically just copies the search UI from the index page into the batch operations page, then uses the search results to populate the archive list. The old behavior is available behind the "Use All Archives" button. Still to be done: more search options including category, flags; better UI in general
This restores the prior behavior in index.js of storing the Awesomplete instance on Index.awesomeplete. That reference wasn't ever used AFAICT, but it might as well stay.
alethiophile
force-pushed
the
batch_refinements
branch
from
1e86fee
to
be7887f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation of some basic filtering for batch operations, as previously discussed in e.g. #893 and #570.
This basically just copies the search UI from the index page to the batch page, then populates the batch archive list from the search results instead of the all-archive list. The old behavior is available behind the "Use all archives" button. The batch page's search bar has tag autocomplete as well; to facilitate this, I moved the loadTagSuggestions function from index into common. That specific function could be pulled out with very little change.
The search UI is not complete here; it lacks categories or any way to apply other search filters. I'm primarily looking for feedback on the basic concept. Personally, this version satisfies one of my big problems with the batch operation interface.