Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Add logging tip when pin is found and tidy up move to find pin #926

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

DominicOram
Copy link
Collaborator

See #924 (not yet fixed but should help to debug)

To test:

  1. Confirm that the tip location will be logged whenever one is found
  2. Confirm that the changes done (as suggested in #906 check limits during pin tip centring #907 (review)) are more readable and pass the tests still

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #926 (f04a07d) into main (9efd61e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #926      +/-   ##
==========================================
- Coverage   93.04%   93.03%   -0.01%     
==========================================
  Files          51       51              
  Lines        2459     2456       -3     
==========================================
- Hits         2288     2285       -3     
  Misses        171      171              
Files Coverage Δ
...hyperion/experiment_plans/pin_tip_centring_plan.py 96.96% <100.00%> (-0.14%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@noemifrisina noemifrisina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, logging message shows up and tests pass.

@DominicOram DominicOram merged commit f4bde5c into main Oct 10, 2023
12 of 16 checks passed
@DominicOram DominicOram deleted the 924_failed_to_find_tip branch October 10, 2023 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants