-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, thank you. The test is failing because you need to patch the device in test_when_blueskyrunner_initiated_then_plans_are_setup_and_devices_connected
, can you please add it in. We should add it in to S03 though but we can merge this without doing so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
@@ -300,6 +300,7 @@ def test_cli_args_parse(): | |||
assert test_args == ("DEBUG", True, True, True) | |||
|
|||
|
|||
@patch("dodal.beamlines.i03.flux") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must: You need to patch the Device, not teh function. I've fixed it :)
Codecov Report
@@ Coverage Diff @@
## main #785 +/- ##
==========================================
+ Coverage 93.25% 93.26% +0.01%
==========================================
Files 37 37
Lines 1854 1857 +3
==========================================
+ Hits 1729 1732 +3
Misses 125 125
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Fixes #632
Link to dodal PR (if required): #113
To test: