Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Fix parameter issues in full_grid_scan #766

Merged
merged 3 commits into from
Jul 14, 2023

Conversation

DominicOram
Copy link
Collaborator

Fixes #759

To test:

  1. Run new tests against main, confirm they fail
  2. Run against this branch, confirm they pass

@DominicOram
Copy link
Collaborator Author

Failing test is due to #760

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #766 (d50ee6d) into main (0b83859) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #766      +/-   ##
==========================================
- Coverage   93.25%   93.25%   -0.01%     
==========================================
  Files          37       37              
  Lines        1854     1853       -1     
==========================================
- Hits         1729     1728       -1     
  Misses        125      125              
Impacted Files Coverage Δ
src/artemis/experiment_plans/full_grid_scan.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@noemifrisina noemifrisina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, tests fail on main but pass here

@DominicOram DominicOram merged commit cf18bbe into main Jul 14, 2023
8 checks passed
@DominicOram DominicOram deleted the 759_fix_full_grid_scan_issues branch July 14, 2023 10:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with v5.0.0 (Part 1)
2 participants