This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Update hyperion to move just the aperture_scatterguard axes required #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicOram
commented
Aug 20, 2024
| @@ -130,7 +130,7 @@ def take_robot_snapshots(oav: OAV, webcam: Webcam, directory: Path): | |||
| def prepare_for_robot_load(composite: RobotLoadThenCentreComposite): | |||
| yield from bps.abs_set( | |||
| composite.aperture_scatterguard, | |||
| AperturePosition.ROBOT_LOAD, | |||
| (ApertureInOut.OUT, None), | |||
| group="prepare_robot_load", | |||
| ) | |||
There was a problem hiding this comment.
We should do a set to (OUT, SMALL) small after this but will need to think about when to wait for it
DominicOram
commented
Aug 20, 2024
| @@ -383,7 +384,9 @@ def set_aperture_for_bbox_size( | |||
| } | |||
| ) | |||
| def set_aperture(): | |||
| yield from bps.abs_set(aperture_device, new_selected_aperture) | |||
| yield from bps.abs_set( | |||
| aperture_device, (ApertureInOut.IN, new_selected_aperture) | |||
There was a problem hiding this comment.
Maybe should be out as we're going to do OAV after this
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DiamondLightSource/mx-bluesky#267
Link to dodal PR (if required):DiamondLightSource/dodal#758
To test: