-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use Vite instead of create-react-app #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two EOF and few suggestions in the CI, apart from that LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are updating stuffs, it is also worth setting up a dependabot in the CI. It keeps all the libraries up-to date. It will open a PR for every version upgrade so you dont have to worry about any new breaking changes.
Good idea, although I'll probably do that in a separate PR. |
Create-react-app is now deprecated, and came with many vulnerabilities in its dependencies. The recommended tool to use now is vite. I have updated cs-web-lib to use this, as well as: