Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phoebus now longer has a
pv_name
field on Graphics widgets Arc, Ellipse, Image, Label, Polyline, Polygon and Rectangle. This has been replaced by amacros
field, which can be used to specifypv_name
or other fields (if needed for rules such as changing background colour). I've added the macros field into these widgets, and also ensured these macros get parsed with the others.I tested this with some widgets that looked like this:
To ensure the macro was passed to the rules