Adopt python-copier-template #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
==========================================
+ Coverage 89.20% 89.37% +0.16%
==========================================
Files 43 43
Lines 1797 1797
==========================================
+ Hits 1603 1606 +3
+ Misses 194 191 -3 ☔ View full report in Codecov by Sentry. |
joeshannon
force-pushed
the
skeleton-to-copier
branch
10 times, most recently
from
37bb6a2
to
05bc896
Compare
Start of adoption of python-copier-template (#359).
This concludes migration to python-copier-template 1.0.0
Blueapi doesn't support Python 3.8
joeshannon
force-pushed
the
skeleton-to-copier
branch
from
aac160a
to
39407dd
Compare
joeshannon
force-pushed
the
skeleton-to-copier
branch
from
d81c914
to
49fe911
Compare
|
This PR contains most of the adoption of the copier template. There will be some subsequent work
The coverage is currently failing as ruff made me fix some issues on lines not already covered. Please check the changes I have made to python code specifically. |
DiamondJoseph
requested changes
Mar 15, 2024
docs/explanations/decisions/0004-switched-to-python-copier-template.md
Outdated
Show resolved
Hide resolved
callumforrester
approved these changes
Mar 15, 2024
…plate.md Co-authored-by: DiamondJoseph <[email protected]>
|
Another issue to make: |
joeshannon
force-pushed
the
skeleton-to-copier
branch
from
10be86a
to
681ee0f
Compare
The run_engine is replaced with a mock.
joeshannon
force-pushed
the
skeleton-to-copier
branch
from
47c6bf6
to
6b35b4c
Compare
Merged
joeshannon
pushed a commit
that referenced
this pull request
Apr 26, 2024
#384 Moved the coverage settings in pyproject.toml from the pytest settings to the tox command. Some merge conflict kept the settings in both places, which interferes with vscode debugging. This PR removes the redundant settings.
ZohebShaikh
pushed a commit
that referenced
this pull request
May 7, 2024
Convert project from python3-pip-skeleton to python-copier-template version 2.0.1. This involves numerous changes most notably restructuring of documentation into a single manual. Additionally many of the pre-commit tools have been replaced with ruff. The ruff ruleset is slightly different to the previous tools so minor changes have been made to the source code. Extensions to this task for completion later: * Convert all documentation to markdown * Fix relative image handling in README * Add more detail about running blueapi tests * Enable ruff's "pyupgrade" ruleset
ZohebShaikh
pushed a commit
that referenced
this pull request
May 7, 2024
#384 Moved the coverage settings in pyproject.toml from the pytest settings to the tox command. Some merge conflict kept the settings in both places, which interferes with vscode debugging. This PR removes the redundant settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.