LIMS-1458: Fix GitHub warnings

[ndg63276]

JIRA ticket: LIMS-1458

Summary:

We should try to decrease the number of JavaScript errors in the "JavaScript build, test and lint" job that runs on creation of a PR.

Changes:

• Change this.attributes.FOO to this.get('FOO')
• Change this.attributes.FOO = 'BAR' to this.set('FOO', 'BAR')
• Move declaration of or rename js variables so that they are not redefined
• Remove unnecessary escape characters eg \:
• Add a log message to avoid having an empty catch statement

Not done

• Use this.$ instead of $ in views - changing seems to break functionality
• Do not silence events - not sure what this does
• Do not access Object.prototype method 'hasOwnProperty' from target object - not sure how to fix this

To test:

• Manually check the code :(
• Check basic Synchweb functions as expected
• Click "Show all checks" in the "All checks have passed" message below, then click Details on the JavaScript job
• Click on the "JavaScript build, test and lint" task, scroll down and see if there are less than about 50 errors.