LIMS-1003: Fix searching of container inspections #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfrn
approved these changes
Sep 12, 2024
ndg63276
added a commit
that referenced
this pull request
Oct 22, 2024
* LIMS-1003: Fix searching of container inspections (#825) Co-authored-by: Mark Williams <[email protected]> * LIMS-380: Fix position of autoPROC images (#831) * LIMS-380: Fix position of autoPROC images * LIMS-380: Just use iframe size of 98% * Set width/height to percentage value (#838) --------- Co-authored-by: Mark Williams <[email protected]> Co-authored-by: Guilherme Francisco <[email protected]> * LIMS-1430: Fix bugs on prepare for data collection page (#829) * LIMS-1430: Allow queuing even if no visible samples * LIMS-1430: Show number of samples to queue * LIMS-1430: Watch all subsamples for changes * LIMS-1430: Remove TODO list * LIMS-1430: Display number is of data collections, not samples * LIMS-1430: Dont allow queueing if hidden data collections are invalid * Update client/src/js/modules/imaging/views/queuecontainer.js Co-authored-by: Guilherme Francisco <[email protected]> --------- Co-authored-by: Mark Williams <[email protected]> Co-authored-by: Guilherme Francisco <[email protected]> * LIMS-1390: Fix searching of data collection groups (#833) Co-authored-by: Mark Williams <[email protected]> * LIMS-1286: Show ERA status on calendar and visits list (#834) Co-authored-by: Mark Williams <[email protected]> * LIMS-1354: Migrate from ActiveMQ to RabbitMQ (#826) * LIMS-1354: Migrate from ActiveMQ to RabbitMQ * Unwrap try...catch * Add routing_key and vhost * Add polyfill for BCMath as php-bcmath extension is not installed but required by php-amqplib for AMQP --------- Co-authored-by: Mark Williams <[email protected]> Co-authored-by: Guilherme Francisco <[email protected]> Co-authored-by: James Hall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1003
Summary:
If you go to the imaging admin page and (under inspections) type something in the search bar, you either get every container ever or an error 500.
The
paginatefunction expects the last 2 values in$argsto be the start and end of the range required. The search code was adding to$argsafter the start/end values had been added, so if you searched for a number, you just got every container ever, and if you searched for text you got an error about a "non-numeric value".Changes:
LOWER()andCONCAT()calls, and appending the search text to $args twice in one go.To test:
38893. Only one result should appear, for proposal in38893.2151_thaum. 14 results should appear, for proposal mx34066.