-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIMS-1334: Allow selection of plate samples already in a group #778
Merged
ndg63276
merged 3 commits into
pre-release/2024-R3.1
from
fix/LIMS-1334/allow-selection-of-plate-samples-already-in-group
Jun 25, 2024
Merged
LIMS-1334: Allow selection of plate samples already in a group #778
ndg63276
merged 3 commits into
pre-release/2024-R3.1
from
fix/LIMS-1334/allow-selection-of-plate-samples-already-in-group
Jun 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Restore EM menu in dropdown (#766) * Pre release/2024 r2.2 (#770) * LIMS-1201: Amend name of XPDF capillary crystal to use user acronym (#738) Co-authored-by: Mark Williams <[email protected]> * LIMS-1256: Remove validation from Local Contact field (#756) Co-authored-by: Mark Williams <[email protected]> * LIMS-667: Make the Requested Imager a required field if a plate is being created (#733) Co-authored-by: Mark Williams <[email protected]> * LIMS-1261: Fix the grid scan heat maps on the VMXi container view (#744) Co-authored-by: Mark Williams <[email protected]> * LIMS-1289: Fix sample and pdb count on protens page (#753) Co-authored-by: Mark Williams <[email protected]> --------- Co-authored-by: Mark Williams <[email protected]> * Pre release/2024 r2.3 (#772) * LIMS-1207: Move Calendar link to top left * LIMS-1207: Move Migrate link to Lab Contacts page * LIMS-1207: Re-order menu, remove Assign Containers * LIMS-1201: Amend name of XPDF capillary crystal to use user acronym (#738) Co-authored-by: Mark Williams <[email protected]> * LIMS-1256: Remove validation from Local Contact field (#756) Co-authored-by: Mark Williams <[email protected]> * LIMS-667: Make the Requested Imager a required field if a plate is being created (#733) Co-authored-by: Mark Williams <[email protected]> * LIMS-1261: Fix the grid scan heat maps on the VMXi container view (#744) Co-authored-by: Mark Williams <[email protected]> * LIMS-1289: Fix sample and pdb count on protens page (#753) Co-authored-by: Mark Williams <[email protected]> * LIMS-1304: Correct the order of before and after snapshots * LIMS-1304: Update to fix typo Co-authored-by: Mark W <[email protected]> * LIMS-1235: Queries for implicit samples and DCs in project time out (#758) Co-authored-by: Mark Williams <[email protected]> * LIMS-1200: CSV file upload ignores first sample (#737) * LIMS-1200: CSV file upload ignores first sample * LIMS-1200: Fix bug uploading csv with one sample --------- Co-authored-by: Mark Williams <[email protected]> * LIMS-1174: Handle blank proposal on visits page (#740) Co-authored-by: Mark Williams <[email protected]> * LIMS-44: Speed up visit query (#759) Co-authored-by: Mark Williams <[email protected]> * LIMS-1059: Add visit column to shipments list (#742) Co-authored-by: Mark Williams <[email protected]> * Restore EM menu in dropdown (#766) (#768) * Add 2.2a changes to 2.3 (#771) * Restore EM menu in dropdown (#766) * Pre release/2024 r2.2 (#770) * LIMS-1201: Amend name of XPDF capillary crystal to use user acronym (#738) Co-authored-by: Mark Williams <[email protected]> * LIMS-1256: Remove validation from Local Contact field (#756) Co-authored-by: Mark Williams <[email protected]> * LIMS-667: Make the Requested Imager a required field if a plate is being created (#733) Co-authored-by: Mark Williams <[email protected]> * LIMS-1261: Fix the grid scan heat maps on the VMXi container view (#744) Co-authored-by: Mark Williams <[email protected]> * LIMS-1289: Fix sample and pdb count on protens page (#753) Co-authored-by: Mark Williams <[email protected]> --------- Co-authored-by: Mark Williams <[email protected]> --------- Co-authored-by: Guilherme Francisco <[email protected]> Co-authored-by: Mark Williams <[email protected]> --------- Co-authored-by: Mark Williams <[email protected]> Co-authored-by: Dominic Oram <[email protected]> Co-authored-by: Guilherme Francisco <[email protected]> --------- Co-authored-by: Guilherme Francisco <[email protected]> Co-authored-by: Mark Williams <[email protected]> Co-authored-by: Dominic Oram <[email protected]>
Looks good to me |
gfrn
approved these changes
Jun 19, 2024
ndg63276
deleted the
fix/LIMS-1334/allow-selection-of-plate-samples-already-in-group
branch
June 25, 2024 09:05
ndg63276
added a commit
that referenced
this pull request
Jul 3, 2024
* LIMS-595: Change Sample Changers/Containers/Stage to Pucks for i15/i15-1 (xpdf) (#579) * LIMS-67: Fix 2 slow queries on imaging admin dashboard (#751) * LIMS-1334: Allow selection of plate samples already in a group (#778) * LIMS-1246: Allow users with all_dewars permission to view all shipments (#752) * LIMS-1351: Switch to simpler arrows (#787) * LIMS-1343: Interface changes based on reviewer suggestions from Conexs paper (#783) * LIMS-1170: Dont use thumbnails for crystal snapshots (#784)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1334
Summary:
Allow a plate sample that is already in a group to be selected for adding to a new group
Changes:
To test: