Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1334: Allow selection of plate samples already in a group #778

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1334

Summary:

Allow a plate sample that is already in a group to be selected for adding to a new group

Changes:

  • Maintain a list of manually selected samples, pass that down to the plate view
  • Use this list to decide whether a click is a select or deselect
  • Use uniqBy instead of concatenating a difference list to return valid samples (this list includes those already in groups)

To test:

  • Open proposal nt37104, go to Sample Groups, then Create Sample Group
  • Select a shipment and a plate (with no coloured samples)
  • Select a few samples and create a group with a name, check the view on the Sample Groups page that this has worked correctly
  • Go back to Create Sample Group, use the same shipment and plate, some samples should now be blue to show they are already in a group
  • Check that clicking on blue samples turns them green, and clicking again turns them blue again
  • Select some previously blue samples and some previously grey samples and create a group.
  • Use the row select, column select, and select all buttons to create more groups. Each should toggle green and blue or grey.
  • Check each group has been created with the correct samples.

gfrn and others added 3 commits May 1, 2024 13:50
* Restore EM menu in dropdown (#766)

* Pre release/2024 r2.2 (#770)

* LIMS-1201: Amend name of XPDF capillary crystal to use user acronym (#738)

Co-authored-by: Mark Williams <[email protected]>

* LIMS-1256: Remove validation from Local Contact field (#756)

Co-authored-by: Mark Williams <[email protected]>

* LIMS-667: Make the Requested Imager a required field if a plate is being created (#733)

Co-authored-by: Mark Williams <[email protected]>

* LIMS-1261: Fix the grid scan heat maps on the VMXi container view (#744)

Co-authored-by: Mark Williams <[email protected]>

* LIMS-1289: Fix sample and pdb count on protens page (#753)

Co-authored-by: Mark Williams <[email protected]>

---------

Co-authored-by: Mark Williams <[email protected]>

* Pre release/2024 r2.3 (#772)

* LIMS-1207: Move Calendar link to top left

* LIMS-1207: Move Migrate link to Lab Contacts page

* LIMS-1207: Re-order menu, remove Assign Containers

* LIMS-1201: Amend name of XPDF capillary crystal to use user acronym (#738)

Co-authored-by: Mark Williams <[email protected]>

* LIMS-1256: Remove validation from Local Contact field (#756)

Co-authored-by: Mark Williams <[email protected]>

* LIMS-667: Make the Requested Imager a required field if a plate is being created (#733)

Co-authored-by: Mark Williams <[email protected]>

* LIMS-1261: Fix the grid scan heat maps on the VMXi container view (#744)

Co-authored-by: Mark Williams <[email protected]>

* LIMS-1289: Fix sample and pdb count on protens page (#753)

Co-authored-by: Mark Williams <[email protected]>

* LIMS-1304: Correct the order of before and after snapshots

* LIMS-1304: Update to fix typo

Co-authored-by: Mark W <[email protected]>

* LIMS-1235: Queries for implicit samples and DCs in project time out (#758)

Co-authored-by: Mark Williams <[email protected]>

* LIMS-1200: CSV file upload ignores first sample (#737)

* LIMS-1200: CSV file upload ignores first sample

* LIMS-1200: Fix bug uploading csv with one sample

---------

Co-authored-by: Mark Williams <[email protected]>

* LIMS-1174: Handle blank proposal on visits page (#740)

Co-authored-by: Mark Williams <[email protected]>

* LIMS-44: Speed up visit query (#759)

Co-authored-by: Mark Williams <[email protected]>

* LIMS-1059: Add visit column to shipments list (#742)

Co-authored-by: Mark Williams <[email protected]>

* Restore EM menu in dropdown (#766) (#768)

* Add 2.2a changes to 2.3 (#771)

* Restore EM menu in dropdown (#766)

* Pre release/2024 r2.2 (#770)

* LIMS-1201: Amend name of XPDF capillary crystal to use user acronym (#738)

Co-authored-by: Mark Williams <[email protected]>

* LIMS-1256: Remove validation from Local Contact field (#756)

Co-authored-by: Mark Williams <[email protected]>

* LIMS-667: Make the Requested Imager a required field if a plate is being created (#733)

Co-authored-by: Mark Williams <[email protected]>

* LIMS-1261: Fix the grid scan heat maps on the VMXi container view (#744)

Co-authored-by: Mark Williams <[email protected]>

* LIMS-1289: Fix sample and pdb count on protens page (#753)

Co-authored-by: Mark Williams <[email protected]>

---------

Co-authored-by: Mark Williams <[email protected]>

---------

Co-authored-by: Guilherme Francisco <[email protected]>
Co-authored-by: Mark Williams <[email protected]>

---------

Co-authored-by: Mark Williams <[email protected]>
Co-authored-by: Dominic Oram <[email protected]>
Co-authored-by: Guilherme Francisco <[email protected]>

---------

Co-authored-by: Guilherme Francisco <[email protected]>
Co-authored-by: Mark Williams <[email protected]>
Co-authored-by: Dominic Oram <[email protected]>
@NKatti2011
Copy link
Collaborator

Looks good to me

@gfrn gfrn self-requested a review June 19, 2024 13:10
@ndg63276 ndg63276 changed the base branch from prerelease to master June 24, 2024 09:34
@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R3.1 June 25, 2024 09:03
@ndg63276 ndg63276 merged commit dcdef9b into pre-release/2024-R3.1 Jun 25, 2024
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-1334/allow-selection-of-plate-samples-already-in-group branch June 25, 2024 09:05
ndg63276 added a commit that referenced this pull request Jul 3, 2024
* LIMS-595: Change Sample Changers/Containers/Stage to Pucks for i15/i15-1 (xpdf) (#579)

* LIMS-67: Fix 2 slow queries on imaging admin dashboard (#751)

* LIMS-1334: Allow selection of plate samples already in a group (#778)

* LIMS-1246: Allow users with all_dewars permission to view all shipments (#752)

* LIMS-1351: Switch to simpler arrows (#787)

* LIMS-1343: Interface changes based on reviewer suggestions from Conexs paper (#783)

* LIMS-1170: Dont use thumbnails for crystal snapshots (#784)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants