Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1246: Allow users with all_dewars permission to view all shipments #752

Conversation

ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Apr 8, 2024

JIRA ticket: LIMS-1246

Summary:

Members of goods handling have the "all_dewars" permission in ISPyB. We should allow them to see all shipments, and print the shipping labels. They should also see the "Logistics" page (/dewars/overview) with the truck icon in the top right.

Unfortunately this PR also allows them to see:

  • A list of all proposals (could be removed but seems useful so they can navigate to a specific shipment)
  • A list of all samples for a proposal
  • A list of all proteins for a proposal
  • A list of all lab contacts for a proposal
  • Registered dewars and containers for a proposal

Does not allow them to see:

  • Any visits or data collections
  • Any containers
  • Any details on samples, proteins, lab contacts

Changes:

  • Set $auth to be true if the user has all_dewars permission, and the page has a prop= property and no id= or visit= properties
  • Show all proposals if user has all_dewars permission
  • Allow lookup of proposal for Shipping page if user has all_dewars permission
  • Remove the isStaff filter on the admin menu in the top right, replace with individual permissions for each icon. Most villages only have fault reports so can be set to fault_view.

To test:

  • Log in as someone from goods handling, test you can navigate via a proposal to a shipment and print shipping labels
  • Test a direct link to a shipment as someone from goods handling
  • Test you cannot see visits or data collections
  • Log in as a 'normal' user, test you can only get to shipments from your proposal
  • Test a direct link to a shipment you should not be able to see
  • Log in as staff, test you can see everything as normal

@ndg63276 ndg63276 changed the title LIMS-1246: Allow users with all_shipments permission to view all shipments LIMS-1246: Allow users with all_dewars permission to view all shipments May 30, 2024
@NKatti2011
Copy link
Collaborator

Not that performant on local, but works fine when deployed.

@ndg63276 ndg63276 changed the base branch from prerelease to master June 24, 2024 09:35
@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R3.1 June 25, 2024 09:03
@ndg63276 ndg63276 merged commit 8574115 into pre-release/2024-R3.1 Jun 25, 2024
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1246/allow-goods-handling-to-view-shipments branch June 25, 2024 09:06
ndg63276 added a commit that referenced this pull request Jul 3, 2024
* LIMS-595: Change Sample Changers/Containers/Stage to Pucks for i15/i15-1 (xpdf) (#579)

* LIMS-67: Fix 2 slow queries on imaging admin dashboard (#751)

* LIMS-1334: Allow selection of plate samples already in a group (#778)

* LIMS-1246: Allow users with all_dewars permission to view all shipments (#752)

* LIMS-1351: Switch to simpler arrows (#787)

* LIMS-1343: Interface changes based on reviewer suggestions from Conexs paper (#783)

* LIMS-1170: Dont use thumbnails for crystal snapshots (#784)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants