Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-67: Fix 2 slow queries on imaging admin dashboard #751

Merged

Conversation

ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Apr 5, 2024

JIRA ticket: LIMS-67

Summary:

The imaging admin dashboard (/admin/imaging, needs privileges) is very slow to load the containers and inspections tables. This PR is to fix these slow queries, trying not to break anything else.

Changes:

  • Change default sorting on container table from bltimestamp to containerid. Some sorts are still slow, but at least the default is fast now.
  • Remove the join to the massive BLSampleImage table from the Inspections query, instead do that as separate smaller queries afterwards and push them into the result.
  • This breaks sorting by the Scored column, but I have added the ability to sort by several other columns as compensation.

To test:

  • Go to /admin/imaging, check the page loads rapidly.
  • Click on one of the plates in the inspection table, check it loads up the Inspections history.
  • Click on a well in the plate and add a score (eg 0 - Clear). Go back to the dashboard and check the Scored column has the value 'Yes'.
  • Check sorting works on all columns in the Inspections table except Adhoc, Manual and Scored.
  • Choose Containers from the main menu, check the containers list loads ok.

@ndg63276 ndg63276 changed the base branch from prerelease to master June 24, 2024 09:35
@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R3.1 June 25, 2024 09:02
@ndg63276 ndg63276 merged commit 3d8d1ba into pre-release/2024-R3.1 Jun 25, 2024
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-67/slow-imaging-admin-dashboard branch June 25, 2024 09:05
ndg63276 added a commit that referenced this pull request Jul 3, 2024
* LIMS-595: Change Sample Changers/Containers/Stage to Pucks for i15/i15-1 (xpdf) (#579)

* LIMS-67: Fix 2 slow queries on imaging admin dashboard (#751)

* LIMS-1334: Allow selection of plate samples already in a group (#778)

* LIMS-1246: Allow users with all_dewars permission to view all shipments (#752)

* LIMS-1351: Switch to simpler arrows (#787)

* LIMS-1343: Interface changes based on reviewer suggestions from Conexs paper (#783)

* LIMS-1170: Dont use thumbnails for crystal snapshots (#784)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants