LIMS-1163: Improve error message when token is invalid #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndg63276
changed the title
MattPrit
previously requested changes
Dec 14, 2023
| @@ -178,13 +187,21 @@ private function processOneTimeUseTokens(): bool | |||
| $need_auth = false; | |||
| $this->dataLayer->deleteOneTimeUseToken($tokenId); | |||
| } | |||
| else | |||
| { | |||
| $err = 'Authorisation token not valid for this URL.'; | |||
There was a problem hiding this comment.
I'm not sure that we would want to tell the user this. Perhaps we should, if a valid token is not found, return a more generic message to the user, e.g. "Invalid one-time authorization token, please go back and try again...", but log the reason internally.
gfrn
reviewed
Jan 10, 2024
gfrn
approved these changes
Jan 10, 2024
ndg63276
deleted the
improvement/LIMS-1163/improve-error-message-when-token-is-invalid
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1163
Summary:
Users complain of not being allowed to print an air waybill after booking a shipment into Diamond.
Changes:
To test: