Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LIMS-1120] Display message when user is not in database #693

Merged
merged 4 commits into from
Nov 23, 2023
Merged

[LIMS-1120] Display message when user is not in database #693

merged 4 commits into from
Nov 23, 2023

Conversation

gfrn
Copy link
Collaborator

@gfrn gfrn commented Nov 21, 2023

JIRA ticket: LIMS-1120

Summary:

Display a message in the login page when an user logs in successfully, but their username matches no entries in the database.

Changes:

  • Check if user exists when exchanging code for token in backend
  • Add message in frontend when backend returns 403

To test:

  • Login with a valid FedID
  • If possible, log in with an email address, and if not, mock out the response of authenticateByCode to return an invalid username.

@gfrn gfrn added javascript Pull requests that update Javascript code improvement php Pull requests that update PHP code labels Nov 21, 2023
@gfrn gfrn requested a review from ndg63276 November 21, 2023 09:03
@gfrn gfrn self-assigned this Nov 21, 2023
@ndg63276
Copy link
Collaborator

Haven't been able to test but the code looks ok to me.

@gfrn gfrn merged commit 9d2d739 into prerelease Nov 23, 2023
2 checks passed
@ndg63276 ndg63276 deleted the improvement/lims-1120/unrecognised-message branch November 24, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndg63276 ndg63276 Awaiting requested review from ndg63276

Assignees

@gfrn gfrn

Labels
improvement javascript Pull requests that update Javascript code php Pull requests that update PHP code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gfrn @ndg63276