LIMS-933: Attach auth header to shipping service requests #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you need to update the configs for prod and staging to have the new urls in? |
John-Holt-Tessella
suggested changes
Sep 29, 2023
| throw new \Exception("Shipping service auth error: no cookie found and basic auth credentials unset"); | ||
| } | ||
|
|
||
| function __construct() |
There was a problem hiding this comment.
Constructing this object will fail if the setting are not set and might fail if they are null. Either:
- make sure this is not constructed if the shipping service is not being used
- make sure the constructor doesn't do anything if the shipping service is not used
John-Holt-Tessella
approved these changes
Sep 29, 2023
John-Holt-Tessella
deleted the
fix/lims-933/use-shipping-service-auth
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-933
Summary:
This change attaches an auth header to shipping service requests. This is either the user access token as a bearer token or basic auth using stored synchweb credentials.
Changes:
To test: