Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-210: Prevent double clicking to create multiple samples #660

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Sep 4, 2023

Ticket: LIMS-210

Changes:

  • We now know that double-clicking on the tick button when editing samples can create 2 samples in the same location. By closing the editor before saving, we prevent that.

Tests:

  • Editing a sample and single clicking creates one sample
  • Editing a sample and double clicking only creates one sample
  • Editing a sample, leaving invalid parameters, clicking should leave the editor open and not create a sample

@ndg63276 ndg63276 merged commit eeb3e2d into prerelease Sep 6, 2023
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-210/duplicated-samples-in-puck-v2 branch September 6, 2023 14:02
MattPrit added a commit that referenced this pull request Oct 5, 2023
* LIMS-222: Apply experimental parameters to all samples (#595)

* LIMS-222: Apply experimental parameters to all samples

* LIMS-222: Fix bug from renaming method

* Use toArray instead of filter and make names better

---------

Co-authored-by: Mark Williams <[email protected]>
Co-authored-by: John Holt <[email protected]>

* LIMS-210: Prevent double clicking to create multiple samples (#660)

* LIMS-210: Prevent double clicking to create multiple samples

* Use loading state to avoid double click

---------

Co-authored-by: Mark Williams <[email protected]>
Co-authored-by: John Holt <[email protected]>

* LIMS-499: Make reciprocal space viewer more obvious (#653)

Co-authored-by: Mark Williams <[email protected]>

* LIMS-395: Display warning if no spots or incomplete PIA (#623)

* LIMS-395: Display a warning on grid scans if no spots found or incomplete PIA results

* LIMS-395: Use new XRC tables

---------

Co-authored-by: Mark Williams <[email protected]>

* LIMS-759: Show multipin samples and their sublocations (#648)

Co-authored-by: Mark Williams <[email protected]>

* LIMS-154: Enable display of all grid scan snapshots in full (#631)

* LIMS-154: Enable display of all grid scan snapshots in full

* Avoid overwriting globally scoped variable n

Co-authored-by: Guilherme Francisco <[email protected]>

---------

Co-authored-by: Mark Williams <[email protected]>
Co-authored-by: Guilherme Francisco <[email protected]>

* LIMS-952: Display xray centring results if running 3d xray centring (#647)

* LIMS-952: Display xray centring results if running 3d xray centring

* LIMS-952: Mark no results as xray centring failure

* LIMS-952: Display message if no diffraction found

---------

Co-authored-by: Mark Williams <[email protected]>

* LIMS-862: Reset registered container after creating container (#628)

Co-authored-by: Mark Williams <[email protected]>

* LIMS-77: Link Lab Contacts to fedids (#622)

* LIMS-77: Link Lab Contacts to fedids

* Use Promise.all rather than $.when

Co-authored-by: Guilherme Francisco <[email protected]>

---------

Co-authored-by: Mark Williams <[email protected]>
Co-authored-by: Guilherme Francisco <[email protected]>

* Fix user data invocation tests

* Revert "LIMS-759: Show multipin samples and their sublocations (#648)"

This reverts commit 5ec00f1.

---------

Co-authored-by: Mark W <[email protected]>
Co-authored-by: Mark Williams <[email protected]>
Co-authored-by: John Holt <[email protected]>
Co-authored-by: Guilherme Francisco <[email protected]>
Co-authored-by: NKatti2011 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants