Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-116: Summary page revamp #606

Merged
merged 60 commits into from
Jul 25, 2023

Conversation

NKatti2011
Copy link
Collaborator

@NKatti2011 NKatti2011 commented Jun 28, 2023

Ticket: LIMS-116

The current summary page currently displays information that is not completely relevant such as exposure time/oscillation. The page revamp involves adding in more useful information and the ability to filter across these variables. The current changes are only visible to staff and if the config is configuredThe changes included are listed below:

  • Add page consisting of columns of requested relevant data including but not limited to overall resIOverSigI2, inner rMeasWithinIPlusIMinus, and outer resolutionLimitHigh.
  • Add ability to remove and add columns in the table for results personalisation
  • Add ability to filter results based on column. Filters include ability to search values greater than, less than, equal to, or like a value that you input.
  • Add grouped results in rows which then expand to reveal further results on row click. Results are grouped by data collection.
  • IFrame introduced as a preview to data collections page.

Testing:

Log in
Navigate to summary page
Check results load

@NKatti2011 NKatti2011 requested review from gfrn and MattPrit June 28, 2023 14:20
api/src/Database/DatabaseConnectionFactory.php Outdated Show resolved Hide resolved
client/src/js/modules/summary/views/summary.vue Outdated Show resolved Hide resolved
client/src/js/app/store/modules/store.summary.js Outdated Show resolved Hide resolved
client/src/js/modules/summary/router.js Outdated Show resolved Hide resolved
client/src/js/modules/summary/views/summary.vue Outdated Show resolved Hide resolved
client/src/js/app/components/custom-accordian.vue Outdated Show resolved Hide resolved
client/src/js/app/components/combo-box.vue Outdated Show resolved Hide resolved
api/src/TemplateParser.php Outdated Show resolved Hide resolved
api/src/Database/Type/PureMySQL.php Show resolved Hide resolved
api/src/Page/Summary.php Outdated Show resolved Hide resolved
@MattPrit
Copy link
Contributor

A couple of extra questions:

  • Can we remove the proposal dropdown?
  • Can we make the iframe render only the data collection component rather than the whole of SynchWeb?

@NKatti2011 NKatti2011 changed the title Feature/lims 116/summary page revamp LIMS-116: Summary page revamp Jul 10, 2023
@NKatti2011 NKatti2011 merged commit e0c0764 into prerelease Jul 25, 2023
1 of 2 checks passed
John-Holt-Tessella added a commit that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants